fix disposeOnUnmount when using react-hot-loader

mobxjs / mobx-react

React bindings for MobX

https://mobx.js.org/react-integration.html

MIT License

4.85k stars 350 forks source link

fix disposeOnUnmount when using react-hot-loader #886

Closed fellmann closed 4 years ago

fellmann commented 4 years ago

Code change checklist

[ ] Added/updated unit tests
[x] Updated changelog
[x] Updated README if applicable

Fixes https://github.com/mobxjs/mobx-react/issues/725 Closed because "Solution is using react-fast-refresh". react-fast-refresh is mostly not production ready. This fix ensures compatibility. I did not manage to recreate react-hot-loader's behavior as unit test.

danielkcz commented 4 years ago

Looks fair enough. Thanks for your contribution!

fellmann commented 4 years ago

Thanks! Any idea when 6.2.3 will be released?

danielkcz commented 4 years ago

Published just now :)