search

mobxjs / mobx-state-tree

Full-featured reactive state management without the boilerplate
https://mobx-state-tree.js.org/
MIT License
6.9k stars 639 forks source link

fix: add checks while creating model #2057

Closed chakrihacker closed 10 months ago

chakrihacker commented 11 months ago

closes #1725

closes https://github.com/mobxjs/mobx-state-tree/issues/1537

chakrihacker commented 10 months ago

@coolsoftwaretyler I am not able to add you as reviewer, Can you please check this??

coolsoftwaretyler commented 10 months ago

@chakrihacker - sure thing. Will you please add a description to this PR and link to any relevant issue(s)?

coolsoftwaretyler commented 10 months ago

Thanks @chakrihacker! I will take a look sometime this week or over the weekend.

coolsoftwaretyler commented 10 months ago

I think this also closes out https://github.com/mobxjs/mobx-state-tree/issues/1537 - edited description as such.

coolsoftwaretyler commented 10 months ago

Looks great! Thanks @chakrihacker. I'll get this in a patch release sometime soon.