search

mobxjs / mobx-state-tree

Full-featured reactive state management without the boilerplate
https://mobx-state-tree.js.org/
MIT License
6.99k stars 641 forks source link

bugfix: fix error judgement on splitCache #2077

Closed luo-occ closed 1 year ago

luo-occ commented 1 year ago

fix the bug of path judgement

inner function of splitCache has error when judging descendant node

node1.path='a/1'
node2.path='a/10'

nodes2.path.indexOf(node1) === 0 // true
// then it will assume node2 is the child of node1, which is not expected

fix solution

add additional judgement of path that contains '/'

chakrihacker commented 1 year ago

Hey @luo-occ Can you provide an example repro for the issue??

coolsoftwaretyler commented 1 year ago

Thanks for the PR @luo-occ, and I'm sorry for any confusion, I think this is actually closed by https://github.com/mobxjs/mobx-state-tree/pull/2054, which had a corresponding issue of https://github.com/mobxjs/mobx-state-tree/issues/2053.

I'm going to close this out because I think we're all good on this, but let me know if the issue persists in versions past 5.2.0, please!