fix: #2138 linter issues with fail function

mobxjs / mobx-state-tree

Full-featured reactive state management without the boilerplate

https://mobx-state-tree.js.org/

MIT License

6.99k stars 641 forks source link

Closed JuanJo4 closed 7 months ago

JuanJo4 commented 8 months ago

It solves #2138, this has happened before (#2137 & #1989) and was solved only for those specific cases, this PR aims to fix once and for all.

This is what I did:

removed fail function and created a new MstError class that extends from Error.
adjusted the calls of the fail function accordingly.
removed unused imports

I've added some basic unit tests, not sure if that's enough.

coolsoftwaretyler commented 8 months ago

Thanks @JuanJo4! I'll take a look today or tomorrow.

coolsoftwaretyler commented 7 months ago

Perfect! Merging.

I'll get a new 6.0.0 release out soon. We're in a preview mode for the next major and this should land there once we ship it.

Thanks for the help, and please let us know if there's anything else you'd like to work on.