chore: target es6 in tsconfig

mobxjs / mobx-state-tree

Full-featured reactive state management without the boilerplate

https://mobx-state-tree.js.org/

MIT License

6.99k stars 641 forks source link

chore: target es6 in tsconfig #2197

Closed coolsoftwaretyler closed 4 months ago

coolsoftwaretyler commented 4 months ago

What does this PR do and why?

Fixes https://github.com/mobxjs/mobx-state-tree/issues/1101 by upgrading our target to es6.

Steps to validate locally

Repro repo should work.

coolsoftwaretyler commented 4 months ago

Ok, so it didn't work with these changes, but the .module export does work if we update our target to ES6 in tsconfig.json.

coolsoftwaretyler commented 4 months ago

I think we're actually gonna ship two tsconfig files and build separately so we can maintain backwards compatibility with older MST versions. Should be able to just ship this build alongside it.

coolsoftwaretyler commented 4 months ago

I'm going to close this for now and revisit once we get a few of the other pending PRs merged in since we're changing up a little in tsconfig anyway. My goal is to put out a new, additional build with an upcoming v7 preview.