search

mobxjs / mobx-vue

🐉 Vue bindings for MobX
MIT License
475 stars 22 forks source link

Proposal for Official Support #1

Closed kuitos closed 6 years ago

kuitos commented 6 years ago

Hi @mweststrate Recently I built this library to combine mobx with vue through a simple api what like mobx-react does, now it released v1.0.0 and reached 100% code coverage already, could you please donate some time to make a review and check is it good enough to move to mobxjs organization?

mweststrate commented 6 years ago

Looks good! Should be compatible out of the box immediately as well with MobX 5, which means that it will support direct manipulation of objects, arrays etc, which is all more cumbersome in Vue ;-)

Feel free to submit an organization move request. I'll add you as collaborator as well.

mweststrate commented 6 years ago

How does this library relate to https://github.com/dwqs/vue-mobx? Should the efforts be combined?

mweststrate commented 6 years ago

N.B. note that moving it to the organisation means that there is a commitment @kuitos to support it from your side? I don't think there are a lot of other experienced Vue users in collaborators team of MobXJS :).

kuitos commented 6 years ago

@mweststrate vue-mobx was not maintained any more, see https://github.com/dwqs/vue-mobx/issues/4 . The author recommended movue . And, the author of movue had raised a question which just mobx-vue solved: https://github.com/nighca/movue/issues/16 .

Both the libraries are inspired by vue-rx, which I think would weaken the mobx power(sorry to @nighca 😜), I will post a article to explain this these days.

note that moving it to the organisation means that there is a commitment @kuitos to support it from your side?

That challenge is what I want!

I don't think there are a lot of other experienced Vue users in collaborators team of MobXJS

Yes that is what I concerned, fortunately I had use mobx-vue in our production to earn experience.

nighca commented 6 years ago

Great effort @kuitos! Let me know if I can offer help.

kuitos commented 6 years ago

Firstly, recommend mobx-vue on movue haha.@nighca :stuck_out_tongue_winking_eye:

nighca commented 6 years ago

@kuitos Sure. I introduced mobx-vue in README. :) By the way, I've got some ideas about mobx-vue and will explain in another issue.

kuitos commented 6 years ago

all right:ok_hand: