search

mobxjs / mobx-vue

🐉 Vue bindings for MobX
MIT License
475 stars 22 forks source link

Most of the tests are failing #18

Closed snaptopixel closed 6 years ago

snaptopixel commented 6 years ago

I was gearing up to start a PR but noticed the bulk of the tests are failing? Is there something wrong with the lib, or are the tests outdated?

kuitos commented 6 years ago

had checked the local and latest travis building, nothing broken yet. Could you have a try to look into the error stack or rebuild the dependencies(delete node_modeuls and rerun npm i) with npm@5 again?

snaptopixel commented 6 years ago

Ok, I had used yarn previously, but following your directions it's working now. Thanks, closing!

kuitos commented 6 years ago

expecting for your pr 😀

snaptopixel commented 6 years ago

Still working on my PR @kuitos, I wanted to re-open this because the tests fail whenever I update vue-test-utils. The only way to get them working again is to revert the change in package.json and package-lock.json, then npm i and they will run again...

kuitos commented 6 years ago

vue-test-utils is beta still, we should keep it locked at current period imo.

kuitos commented 6 years ago

Had submitted a pr to fix this issue: https://github.com/vuejs/vue-test-utils/pull/856

kuitos commented 6 years ago

fixed

snaptopixel commented 6 years ago

Great work @kuitos! Thanks for looking into it and fixing vue-test-utils ;)