search

mobxjs / mobx.dart

MobX for the Dart language. Hassle-free, reactive state-management for your Dart and Flutter apps.
https://mobx.netlify.app
MIT License
2.4k stars 310 forks source link

test: .packages is deprecated #811

Closed amondnet closed 2 years ago

amondnet commented 2 years ago

When use flutter 3.0.0, tests fails.

cd mobx_codegen
../tool/coverage.sh
Generating LCOV report...
The top level `pub` command is deprecated. Use `dart pub` instead.
Building package executable... 
Built coverage:format_coverage.
Unhandled exception:
FormatException: Unexpected character (at character 1)
# This file is deprecated. Tools should instead consume 
^

#0      throwError (package:package_config/src/errors.dart:32:35)
#1      parsePackageConfigString (package:package_config/src/package_config_json.dart:54:12)
#2      PackageConfig.parseString (package:package_config/src/package_config.dart:94:7)
#3      Resolver._parsePackages (package:coverage/src/resolver.dart:115:23)
#4      Resolver.create (package:coverage/src/resolver.dart:34:13)
#5      HitMap.parseJson (package:coverage/src/hitmap.dart:45:37)
#6      HitMap.parseFiles (package:coverage/src/hitmap.dart:173:41)
#7      main (file:///Users/lms/.pub-cache/hosted/pub.dartlang.org/coverage-1.3.1/bin/format_coverage.dart:66:31)
#8      _delayEntrypointInvocation.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:295:32)
#9      _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:192:12)

.packages : 

# This file is deprecated. Tools should instead consume 
# `.dart_tool/package_config.json`.
# 
# For more info see: https://dart.dev/go/dot-packages-deprecation

Failed tests:

Signed-off-by: Minsu Lee amond@amond.net

netlify[bot] commented 2 years ago

Deploy Preview for mobx canceled.

Name Link
Latest commit 888167f8c5818bae104638698694b1a63e4779ca
Latest deploy log https://app.netlify.com/sites/mobx/deploys/627dfeb05c378b0008e7b2bd
codecov[bot] commented 2 years ago

Codecov Report

Merging #811 (888167f) into master (9c4eb1d) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #811   +/-   ##
=======================================
  Coverage   98.70%   98.70%           
=======================================
  Files          56       56           
  Lines        1934     1934           
=======================================
  Hits         1909     1909           
  Misses         25       25
Flag Coverage Δ
flutter_mobx 100.00% <ø> (ø)
mobx 98.18% <ø> (ø)
mobx_codegen 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9c4eb1d...888167f. Read the comment docs.

amondnet commented 1 year ago

@all-contributors please add @amondnet for test

allcontributors[bot] commented 1 year ago

@amondnet

I've put up a pull request to add @amondnet! :tada: