mobxjs / mobx.dart

MobX for the Dart language. Hassle-free, reactive state-management for your Dart and Flutter apps.
https://mobx.netlify.app
MIT License
2.4k stars 310 forks source link

Add no_leading_underscores rule to ignore_for_file in mobx_codegen #817

Closed ko16a46 closed 2 years ago

ko16a46 commented 2 years ago

Recommended rules from the lints package now include the no_leading_underscores_for_local_identifiers rule

The default generated store code with actions breaks this rule, causing the linter to complain

Add the rule to the ignore_for_file part of the template, to pacify the analyzer

Fixes #816

netlify[bot] commented 2 years ago

Deploy Preview for mobx canceled.

Name Link
Latest commit f79a4f38249acced08f94aa1516427878943587b
Latest deploy log https://app.netlify.com/sites/mobx/deploys/6283471e3638940008341acd
fzyzcjy commented 2 years ago

LGTM if CI passes, btw you should bump the version

fzyzcjy commented 2 years ago

@pavanpodila Shall we modify the PR template such that there is a tickbox for "you have bumped the version", otherwise reviewers have to say it again and again

ko16a46 commented 2 years ago

Thanks! I bumped the version and added a changelog entry accordingly

pavanpodila commented 2 years ago

@pavanpodila Shall we modify the PR template such that there is a tickbox for "you have bumped the version", otherwise reviewers have to say it again and again

Yes please. Can we create a template for this? There are few other instructions around change log, use of set versions command etc.

fzyzcjy commented 2 years ago

Can we create a template for this?

https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/creating-a-pull-request-template-for-your-repository

codecov[bot] commented 2 years ago

Codecov Report

Merging #817 (5eb425d) into master (635c88c) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 5eb425d differs from pull request most recent head f79a4f3. Consider uploading reports for the commit f79a4f3 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #817   +/-   ##
=======================================
  Coverage   98.81%   98.81%           
=======================================
  Files          56       56           
  Lines        1933     1933           
=======================================
  Hits         1910     1910           
  Misses         23       23           
Flag Coverage Δ
flutter_mobx 100.00% <ø> (ø)
mobx 98.32% <ø> (ø)
mobx_codegen 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mobx_codegen/lib/src/template/store_file.dart 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 635c88c...f79a4f3. Read the comment docs.

ko16a46 commented 2 years ago

Got it, ran the set:version command using npm and committed the changes, thanks

pavanpodila commented 2 years ago

@all-contributors add @ko16a46 for code

allcontributors[bot] commented 2 years ago

@pavanpodila

I've put up a pull request to add @ko16a46! :tada: