mobxjs / mobx.dart

MobX for the Dart language. Hassle-free, reactive state-management for your Dart and Flutter apps.

https://mobx.netlify.app

MIT License

2.4k stars 310 forks source link

Refactor atom.dart to make code cleaner #854

Closed fzyzcjy closed 1 year ago

fzyzcjy commented 2 years ago

Describe the changes proposed in this Pull Request.

If the PR fixes a specific issue, reference the issue with Fixes #.

Pull Request Checklist

[x] If the changes are being made to code, ensure the version in pubspec.yaml is updated.
[x] Increment the major/minor/patch/patch-count, depending on the complexity of change
[x] Add the necessary unit tests to ensure the coverage does not drop
[x] Update the Changelog to include all changes made in this PR
[x] Run the set:versions command using npm or yarn. You can find this command in the package.json file in the root directory
[x] Include the necessary reviewers for the PR
[x] Update the docs if there are any API changes or additions to functionality

netlify[bot] commented 2 years ago

Deploy Preview for mobx canceled.

Name	Link
Latest commit	09edd47318c7f25f381fa16126f7192545bd9916
Latest deploy log	https://app.netlify.com/sites/mobx/deploys/637112aae2e59d00099541f1

codecov[bot] commented 2 years ago

Codecov Report

Merging #854 (9ef80aa) into master (13b7e6d) will decrease coverage by 0.01%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #854      +/-   ##
==========================================
- Coverage   98.96%   98.95%   -0.01%     
==========================================
  Files          55       55              
  Lines        1924     1922       -2     
==========================================
- Hits         1904     1902       -2     
  Misses         20       20

Flag	Coverage Δ
flutter_mobx	`100.00% <ø> (ø)`
mobx	`98.53% <100.00%> (-0.01%)`	:arrow_down:
mobx_codegen	`100.00% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
mobx/lib/src/core/atom.dart	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 13b7e6d...9ef80aa. Read the comment docs.