mobxjs / mobx.dart

MobX for the Dart language. Hassle-free, reactive state-management for your Dart and Flutter apps.
https://mobx.netlify.app
MIT License
2.4k stars 310 forks source link

`disableErrorBoundaries` will not only affect `Reaction`s, but also things like `Computed`s, so the original doc is wrong and should say `Derivation`s #861

Closed fzyzcjy closed 2 years ago

fzyzcjy commented 2 years ago

Describe the changes proposed in this Pull Request.

If the PR fixes a specific issue, reference the issue with Fixes #.


Pull Request Checklist

netlify[bot] commented 2 years ago

Deploy Preview for mobx ready!

Name Link
Latest commit abe32d9d769411357b4a32ac1f597d379bf0719e
Latest deploy log https://app.netlify.com/sites/mobx/deploys/6327c72a6b246a00086460e9
Deploy Preview https://deploy-preview-861--mobx.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

codecov[bot] commented 2 years ago

Codecov Report

Merging #861 (abe32d9) into master (e56e2c4) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #861   +/-   ##
=======================================
  Coverage   98.90%   98.90%           
=======================================
  Files          55       55           
  Lines        1920     1920           
=======================================
  Hits         1899     1899           
  Misses         21       21           
Flag Coverage Δ
flutter_mobx 100.00% <ø> (ø)
mobx 98.45% <ø> (ø)
mobx_codegen 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mobx/lib/src/core/context.dart 97.16% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e56e2c4...abe32d9. Read the comment docs.

amondnet commented 2 years ago

@fzyzcjy melos run set_version instead of npm run set:versions