mobxjs / mobx.dart

MobX for the Dart language. Hassle-free, reactive state-management for your Dart and Flutter apps.
https://mobx.netlify.app
MIT License
2.4k stars 310 forks source link

Remove `ObservableSet.linkedHashSetFrom()` and use `Set` by default #869

Closed pr-1 closed 2 years ago

pr-1 commented 2 years ago

Fixes #868.


Pull Request Checklist

netlify[bot] commented 2 years ago

Deploy Preview for mobx ready!

Name Link
Latest commit 025148aa939a70daeaf8ba9f8816b14a80a051fa
Latest deploy log https://app.netlify.com/sites/mobx/deploys/63273eb57221b800082776d4
Deploy Preview https://deploy-preview-869--mobx.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

codecov[bot] commented 2 years ago

Codecov Report

Merging #869 (025148a) into master (9b7a00d) will increase coverage by 0.10%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #869      +/-   ##
==========================================
+ Coverage   98.80%   98.90%   +0.10%     
==========================================
  Files          55       55              
  Lines        1925     1920       -5     
==========================================
- Hits         1902     1899       -3     
+ Misses         23       21       -2     
Flag Coverage Δ
flutter_mobx 100.00% <ø> (ø)
mobx 98.45% <100.00%> (+0.14%) :arrow_up:
mobx_codegen 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...src/api/observable_collections/observable_set.dart 100.00% <100.00%> (+2.35%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9b7a00d...025148a. Read the comment docs.

pr-1 commented 2 years ago

@fzyzcjy @pavanpodila Please have a look

fzyzcjy commented 2 years ago

Approve after the final change

pavanpodila commented 2 years ago

resolve conflicts pls before merge @pr-1

pr-1 commented 2 years ago

Updated version to 2.0.8 @pavanpodila Please let me know if that is correct or this change should go in patch-count . Resolved conflicts.

pavanpodila commented 2 years ago

Also there are some hygiene changes being pushed into main. Please take a pull from that as well (possibly in 30 mins). @pr-1