mobxjs / mobx.dart

MobX for the Dart language. Hassle-free, reactive state-management for your Dart and Flutter apps.
https://mobx.netlify.app
MIT License
2.4k stars 310 forks source link

update analyzer version to `>=4.4.0 <6.0.0` #877

Closed amondnet closed 1 year ago

amondnet commented 2 years ago

Describe the changes proposed in this Pull Request.

If the PR fixes a specific issue, reference the issue with Fixes #.

Fixes #875 Fixes #850


Pull Request Checklist

netlify[bot] commented 2 years ago

Deploy Preview for mobx canceled.

Name Link
Latest commit a86b76938d81505b8fde84450592b92ccc9e6fed
Latest deploy log https://app.netlify.com/sites/mobx/deploys/63711763e6a33500081299c8
codecov[bot] commented 2 years ago

Codecov Report

Merging #877 (a86b769) into master (0391ef0) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #877   +/-   ##
=======================================
  Coverage   98.95%   98.95%           
=======================================
  Files          55       55           
  Lines        1923     1923           
=======================================
  Hits         1903     1903           
  Misses         20       20           
Flag Coverage Δ
flutter_mobx 100.00% <ø> (ø)
mobx 98.53% <ø> (ø)
mobx_codegen 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mobx_codegen/lib/src/type_names.dart 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0391ef0...a86b769. Read the comment docs.

tim-eucalyptus commented 2 years ago

I'm hoping this gets merged ASAP and we get a new release! Thanks!

fzyzcjy commented 2 years ago

LGTM but ci seems to fail? please fix it before merging if possible :)

amondnet commented 2 years ago

@fzyzcjy Maybe mocktail has a problem with dart beta.

amondnet commented 2 years ago

https://github.com/felangel/mocktail/issues/159

tim-eucalyptus commented 2 years ago

Fails on 3 tests on beta.

amondnet commented 2 years ago

https://github.com/felangel/mocktail/issues/159#issuecomment-1287124400

amondnet commented 2 years ago

879

pavanpodila commented 2 years ago

There are some failing tests in mobx. Can you see @amondnet ?

HudsonAfonso commented 1 year ago

news?

tim-eucalyptus commented 1 year ago

All checks have now passed. Ready to merge! :)