mobxjs / mobx.dart

MobX for the Dart language. Hassle-free, reactive state-management for your Dart and Flutter apps.
https://mobx.netlify.app
MIT License
2.39k stars 311 forks source link

test: fix tests in dart 2.19 #879

Closed amondnet closed 1 year ago

amondnet commented 1 year ago

Describe the changes proposed in this Pull Request.

If the PR fixes a specific issue, reference the issue with Fixes #.

Dart 2.19 doesn't delegate inaccessible private names to noSuchMethod.

https://github.com/dart-lang/sdk/blob/main/CHANGELOG.md#2190 https://github.com/dart-lang/language/issues/2020 https://github.com/dart-lang/sdk/issues/49687 https://github.com/dart-lang/site-www/issues/4263

https://github.com/mobxjs/mobx.dart/blob/master/mobx/test/observable_test.dart

The test fails on dart 2.19.

https://github.com/mobxjs/mobx.dart/actions/runs/3262020308/jobs/5359681093


Pull Request Checklist

netlify[bot] commented 1 year ago

Deploy Preview for mobx canceled.

Name Link
Latest commit c6e238c68278fce61ed2ed4631facf3dc8d54286
Latest deploy log https://app.netlify.com/sites/mobx/deploys/636b234a6afa160009d17d24
codecov[bot] commented 1 year ago

Codecov Report

Merging #879 (5f7d132) into master (021f4a0) will decrease coverage by 1.04%. The diff coverage is 100.00%.

:exclamation: Current head 5f7d132 differs from pull request most recent head c6e238c. Consider uploading reports for the commit c6e238c to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##            master     #879      +/-   ##
===========================================
- Coverage   100.00%   98.95%   -1.05%     
===========================================
  Files            5       55      +50     
  Lines           97     1923    +1826     
===========================================
+ Hits            97     1903    +1806     
- Misses           0       20      +20     
Flag Coverage Δ
flutter_mobx 100.00% <ø> (ø)
mobx 98.53% <100.00%> (?)
mobx_codegen 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mobx/lib/src/core.dart 100.00% <ø> (ø)
mobx/lib/src/core/atom.dart 100.00% <100.00%> (ø)
mobx/lib/src/core/computed.dart 100.00% <100.00%> (ø)
mobx/lib/src/core/context.dart 97.16% <100.00%> (ø)
mobx/lib/src/core/reaction.dart 98.52% <100.00%> (ø)
mobx/lib/src/core/action.dart 100.00% <0.00%> (ø)
mobx/lib/src/utils.dart 100.00% <0.00%> (ø)
mobx_codegen/lib/src/type_names.dart 100.00% <0.00%> (ø)
mobx_codegen/lib/src/template/store.dart 100.00% <0.00%> (ø)
...src/api/extensions/primitive_types_extensions.dart 0.00% <0.00%> (ø)
... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 021f4a0...c6e238c. Read the comment docs.

tim-eucalyptus commented 1 year ago

Would be great to see this merged as it's holding up: https://github.com/mobxjs/mobx.dart/pull/877. Thanks!

tim-eucalyptus commented 1 year ago

Hey can someone please merge this already? It's really holding up our project as we cannot update to freezed 2.2.1 with a critical bug fix.

tim-eucalyptus commented 1 year ago

Any update on this??

HudsonAfonso commented 1 year ago

news?