mobxjs / mobx.dart

MobX for the Dart language. Hassle-free, reactive state-management for your Dart and Flutter apps.
https://mobx.netlify.app
MIT License
2.39k stars 310 forks source link

Observer excludedchild #958

Closed subzero911 closed 9 months ago

subzero911 commented 9 months ago

I got feedback from my fellows that it's unclear that "withChild" is actually "without child"! So I renamed Observer.withChild to Observer.excludedChild.


Pull Request Checklist

codecov[bot] commented 9 months ago

Codecov Report

Merging #958 (9741494) into main (d7dbbf5) will not change coverage. The diff coverage is 100.00%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/mobxjs/mobx.dart/pull/958/graphs/tree.svg?width=650&height=150&src=pr&token=YjGMFvwbrl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mobxjs)](https://app.codecov.io/gh/mobxjs/mobx.dart/pull/958?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mobxjs) ```diff @@ Coverage Diff @@ ## main #958 +/- ## ======================================= Coverage 98.99% 98.99% ======================================= Files 57 57 Lines 1998 1998 ======================================= Hits 1978 1978 Misses 20 20 ``` | [Flag](https://app.codecov.io/gh/mobxjs/mobx.dart/pull/958/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mobxjs) | Coverage Δ | | |---|---|---| | [flutter_mobx](https://app.codecov.io/gh/mobxjs/mobx.dart/pull/958/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mobxjs) | `100.00% <100.00%> (ø)` | | | [mobx](https://app.codecov.io/gh/mobxjs/mobx.dart/pull/958/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mobxjs) | `98.55% <ø> (ø)` | | | [mobx_codegen](https://app.codecov.io/gh/mobxjs/mobx.dart/pull/958/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mobxjs) | `100.00% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mobxjs#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/mobxjs/mobx.dart/pull/958?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mobxjs) | Coverage Δ | | |---|---|---| | [flutter\_mobx/lib/src/observer.dart](https://app.codecov.io/gh/mobxjs/mobx.dart/pull/958?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mobxjs#diff-Zmx1dHRlcl9tb2J4L2xpYi9zcmMvb2JzZXJ2ZXIuZGFydA==) | `100.00% <100.00%> (ø)` | | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/mobxjs/mobx.dart/pull/958?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mobxjs). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mobxjs) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/mobxjs/mobx.dart/pull/958?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mobxjs). Last update [d7dbbf5...9741494](https://app.codecov.io/gh/mobxjs/mobx.dart/pull/958?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mobxjs). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mobxjs).
subzero911 commented 9 months ago

@pavanpodila

netlify[bot] commented 9 months ago

Deploy Preview for mobx canceled.

Name Link
Latest commit 974149495056341e9c2013cea8c1d830f366ea67
Latest deploy log https://app.netlify.com/sites/mobx/deploys/656071d0812fba0008b949b9
pavanpodila commented 9 months ago

Can we also add a quick documentation item for the Observer: https://mobx.netlify.app/api/observers. Then we are done with the basics.

Essentially adding a documentation note for withBuiltChild factory method

subzero911 commented 9 months ago

Okay, I'll try. But didn't edit the docs before (specifically, this MDX format).

pavanpodila commented 9 months ago

Okay, I'll try. But didn't edit the docs before (specifically, this MDX format).

Ok, let's do this. We can close this PR for code and create a separate one for the docs