mobxjs / mobx

Simple, scalable state management.
http://mobx.js.org
MIT License
27.56k stars 1.78k forks source link

fix(eslint-plugin-mobx)!: invert exhausive-make-observable autofix #3877

Closed kade-robertson closed 6 months ago

kade-robertson commented 6 months ago

To avoid changing behaviour of existing logic, the autofix for this rule should specify a false annotation to avoid changing code behaviour.

Code change checklist

changeset-bot[bot] commented 6 months ago

🦋 Changeset detected

Latest commit: 7341f711ac5fb63415272ec234f9ebe16aa9161c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ------------------ | ----- | | eslint-plugin-mobx | Minor |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

urugator commented 6 months ago

Hi, please see https://github.com/mobxjs/mobx/issues/3876#issuecomment-2119001806 Feel free to improve wording of error message.