Support prop schemas for "*" properties

mobxjs / serializr

Serialize and deserialize complex object graphs to and from JSON and Javascript classes

MIT License

766 stars 52 forks source link

Support prop schemas for "*" properties #105

Closed pyrogenic closed 5 years ago

pyrogenic commented 5 years ago

Issue

"*" properties only allow primitive values, but there are numerous use cases where complex objects are the values of a dictionary.

Solution

Allow "*" to have a PropSchema value.

Dependancies

[x] #99 Allow serializing plain objects by specifying constructor
[x] #104 Support optional properties

coveralls commented 5 years ago

Coverage increased (+0.3%) to 91.68% when pulling 3d37deab77906fa4b7c8e09ba4784409724330ae on pyrogenic:star_schema into a9860b61d1d9deba5a13a85b69438a01ea74ad69 on mobxjs:master.

mweststrate commented 5 years ago

Hi @pyrogenic! Superficially speaking changes look good to me! However, I havent worked on this code base for the past 2 or 3 years. If you want, I can make you a maintainer of this repo, and add npm publish permissions as well, enabling you to release once you feel comfortable about it.

I did note that the yarn.lock file has been removed. Are you using npm? Would you mind running yarn to make sure the lock file is preserved?

Thanks!

mweststrate commented 5 years ago

awesome, feel free to add your colleagues! I think things are best reviewed by people currently using it, which doesn't include me at the moment :)

pyrogenic commented 5 years ago

@mweststrate restored lockfile 8cf098b