search

mobxjs / serializr

Serialize and deserialize complex object graphs to and from JSON and Javascript classes
MIT License
766 stars 52 forks source link

update readme; fix #51 and add test #52

Closed alexggordon closed 7 years ago

alexggordon commented 7 years ago

fixes 51 by passing context to custom deserializers

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 95.585% when pulling 5cc5b083ee8d647a4c3c353d827e73c948f4e2a4 on issue51 into 5969581a88c3e52f7639f42b95d279d44704fea8 on master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 95.585% when pulling 83221e3b19c1b0bbc9a6eafe57c467a0b305a8e1 on issue51 into 5969581a88c3e52f7639f42b95d279d44704fea8 on master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 95.585% when pulling 5b902309041a6c2db49d69403fc40fa77de535cf on issue51 into 5969581a88c3e52f7639f42b95d279d44704fea8 on master.

mweststrate commented 7 years ago

@alexggordon sorry, currently on holiday, so didn't see the changes earlier! Just reviewed them and looking good.

I think I didn't give you publish rights on npm yet, can you share your npm user name, then I'll add you as maintainer and you will be able to publish new versions

alexggordon commented 7 years ago

@mweststrate glad they looked good!

my NPM username is alexggordon, and that would be great! Thanks!

mweststrate commented 7 years ago

Added you as owner to the repo. New releases can be published by running ./publish.js (it is an ancient script I kept copying over from project to project, so feel free to replace it with something more sophisticated, like https://www.npmjs.com/package/np)

Op do 3 aug. 2017 om 15:54 schreef Alex Gordon notifications@github.com:

@mweststrate https://github.com/mweststrate glad they looked good!

my NPM username is alexggordon, and that would be great! Thanks!

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/mobxjs/serializr/pull/52#issuecomment-319975592, or mute the thread https://github.com/notifications/unsubscribe-auth/ABvGhPPcl-FKSkGiHhBosGKTUEL-fLZjks5sUdEJgaJpZM4Olvux .