moby / buildkit-bench

Set of benchmarks for BuildKit
https://moby.github.io/buildkit-bench/
Apache License 2.0
0 stars 2 forks source link

build each ref and merge them in tests image #17

Closed crazy-max closed 2 months ago

crazy-max commented 2 months ago

In https://github.com/moby/buildkit-bench/pull/8 we were building each sandbox for a specific ref and run them also independently. This is an issue as we want to run tests for all refs within the same public GitHub Runner to avoid incorrect bench as hardware is not the same across their infrastructure.

With this change we are still building each ref on a dedicated runner to reduce build time but merge them within the sandbox. This also allows us to workaround the cache issue when using names contexts (#3).

crazy-max commented 2 months ago

This also allows us to workaround the cache issue when using names contexts (#3).

Same issue as #3 but looks like this is not related to named context but a combination of ADD --keep-git-dir=true and BUILDKIT_CONTEXT_KEEP_GIT_DIR=1 that invalidates the cache which is very odd: https://github.com/moby/buildkit-bench/actions/runs/10557685498/job/29245797478#step:4:270