moby / buildkit

concurrent, cache-efficient, and Dockerfile-agnostic builder toolkit
https://github.com/moby/moby/issues/34227
Apache License 2.0
8.18k stars 1.16k forks source link

Support remote snapshotter through containerd-worker-snapshotter other than stargz #2110

Open liulanzheng opened 3 years ago

liulanzheng commented 3 years ago

What is the problem you're trying to solve

As containerd remote snapshotter allows users to implement their own remote snapshotters. But in buildkit, only stargz is supported for some judgment is hardcode to 'stargz'. And also some labels needed by remote snapshotters are not passed or no method provided to pass to snapshotters apis.

Describe the solution you'd like

The most important is pass the basic labels like "containerd.io/snapshot.ref" to containerd-worker-snapshotter preprare api other than startgz and handle the response. It is better to provide a method that users can pass their own labels, like the image reference or layer annotations.

liulanzheng commented 3 years ago

It is better to perform as the cri snapshot annotations, which pass image ref and annotations to snapshotter.

antoinerg commented 2 months ago

Is this still a current limitation?