search

moby / buildkit

concurrent, cache-efficient, and Dockerfile-agnostic builder toolkit
https://github.com/moby/moby/issues/34227
Apache License 2.0
7.85k stars 1.09k forks source link

panic: Fail in goroutine after TestCacheMountLockedRefs has completed #3191

Open jedevc opened 1 year ago

jedevc commented 1 year ago

https://github.com/moby/buildkit/actions/runs/3274483652/jobs/5388072103#step:5:986

panic: Fail in goroutine after TestCacheMountLockedRefs has completed

goroutine 14 [running]:
testing.(*common).Fail(0xc000084680)
    C:/hostedtoolcache/windows/go/1.19.2/x64/src/testing/testing.go:824 +0xe5
testing.(*common).Errorf(0xc000084680, {0xb7a8e9?, 0xc000084680?}, {0xc000048290?, 0x18a465?, 0xc0000c8110?})
    C:/hostedtoolcache/windows/go/1.19.2/x64/src/testing/testing.go:941 +0x65
github.com/stretchr/testify/assert.Fail({0x1deae5c1d38, 0xc000084680}, {0xc000116000, 0x3ea}, {0x0, 0x0, 0x0})
    D:/a/buildkit/buildkit/vendor/github.com/stretchr/testify/assert/assertions.go:262 +0x384
github.com/stretchr/testify/assert.NoError({0x1deae5c1d38, 0xc000084680}, {0xcdd220, 0xc0000f84b0}, {0x0, 0x0, 0x0})
    D:/a/buildkit/buildkit/vendor/github.com/stretchr/testify/assert/assertions.go:1334 +0x105
github.com/stretchr/testify/require.NoError({0xce1790, 0xc000084680}, {0xcdd220, 0xc0000f84b0}, {0x0, 0x0, 0x0})
    D:/a/buildkit/buildkit/vendor/github.com/stretchr/testify/require/require.go:1261 +0x96
github.com/moby/buildkit/solver/llbsolver/mounts.TestCacheMountLockedRefs.func2()
    D:/a/buildkit/buildkit/solver/llbsolver/mounts/mount_test.go:291 +0x98
created by github.com/moby/buildkit/solver/llbsolver/mounts.TestCacheMountLockedRefs
    D:/a/buildkit/buildkit/solver/llbsolver/mounts/mount_test.go:289 +0x74a
FAIL    github.com/moby/buildkit/solver/llbsolver/mounts    41.347s

Seems maybe related to the timeout issue fixed by https://github.com/moby/buildkit/pull/3074 and friends? Or maybe https://github.com/moby/buildkit/issues/1685 (an old one)?

CC @crazy-max

crazy-max commented 1 year ago

As discussed this might be an issue with the Windows runner. Will double check on this and find out if resource allocation change between runs on Windows runners.

crazy-max commented 1 year ago

Still persistent: https://github.com/moby/buildkit/actions/runs/4233792838/jobs/7355204977#step:5:1038

--- FAIL: TestCacheMountLockedRefs (19.55s)
panic: Fail in goroutine after TestCacheMountLockedRefs has completed

goroutine 10 [running]:
testing.(*common).Fail(0xc0003f1ba0)
    C:/hostedtoolcache/windows/go/1.19.5/x64/src/testing/testing.go:824 +0xe5
testing.(*common).Errorf(0xc0003f1ba0, {0x153a10f?, 0xc0003f1ba0?}, {0xc0000e2120?, 0xb0a5e5?, 0xc00027a190?})
    C:/hostedtoolcache/windows/go/1.19.5/x64/src/testing/testing.go:941 +0x65
github.com/stretchr/testify/assert.Fail({0x1e4cd353778, 0xc0003f1ba0}, {0xc000116000, 0x3ea}, {0x0, 0x0, 0x0})
    D:/a/buildkit/buildkit/vendor/github.com/stretchr/testify/assert/assertions.go:264 +0x384
github.com/stretchr/testify/assert.NoError({0x1e4cd353778, 0xc0003f1ba0}, {0x16a3860, 0xc00029b560}, {0x0, 0x0, 0x0})
    D:/a/buildkit/buildkit/vendor/github.com/stretchr/testify/assert/assertions.go:1392 +0x105
github.com/stretchr/testify/require.NoError({0x16a80a0, 0xc0003f1ba0}, {0x16a3860, 0xc00029b560}, {0x0, 0x0, 0x0})
    D:/a/buildkit/buildkit/vendor/github.com/stretchr/testify/require/require.go:1261 +0x96
github.com/moby/buildkit/solver/llbsolver/mounts.TestCacheMountLockedRefs.func2()
    D:/a/buildkit/buildkit/solver/llbsolver/mounts/mount_test.go:291 +0x98
created by github.com/moby/buildkit/solver/llbsolver/mounts.TestCacheMountLockedRefs
    D:/a/buildkit/buildkit/solver/llbsolver/mounts/mount_test.go:289 +0x74a
FAIL    github.com/moby/buildkit/solver/llbsolver/mounts    30.424s