search

moby / buildkit

concurrent, cache-efficient, and Dockerfile-agnostic builder toolkit
https://github.com/moby/moby/issues/34227
Apache License 2.0
8.11k stars 1.14k forks source link

bridge network mode has to be tested in the CI #4545

Open AkihiroSuda opened 9 months ago

AkihiroSuda commented 9 months ago

Follow-up to:

We already have testBridgeNetworking in client/client_test.go (https://github.com/moby/buildkit/pull/1073 , Merged on Jul 19, 2019), but this is not relevant to the PR above https://github.com/moby/buildkit/blob/585efdcdd4bce9b25fdf613b0ba3c36c9fc6259f/client/client_test.go#L312-L332

AkihiroSuda commented 9 months ago

The test has to cover this too

tonistiigi commented 8 months ago

You think we should run the whole test suite again? With a random worker?

We do run all tests through CNI (bridge) in CI. The setup code is different though.