search

moby / buildkit

concurrent, cache-efficient, and Dockerfile-agnostic builder toolkit
https://github.com/moby/moby/issues/34227
Apache License 2.0
7.83k stars 1.09k forks source link

Lint test needing fix. #5083

Closed daghack closed 4 days ago

daghack commented 1 week ago

In https://github.com/moby/buildkit/pull/5058, we observe a failing test where there is a delta in one of the errors we expect to receive.

    dockerfile_lint_test.go:1078: 
            Error Trace:    /src/frontend/dockerfile/dockerfile_lint_test.go:1030
                                        /src/frontend/dockerfile/dockerfile_lint_test.go:1078
            Error:          Error message not equal:
                            expected: "failed to solve: base name (${BAR}) should not be blank"
                            actual  : "failed to run Build function: base name (${BAR}) should not be blank"
            Test:           TestIntegration/TestWarningsBeforeError/worker=oci-rootless/frontend=client/warntype=progress
=== RUN   TestIntegration/TestWarningsBeforeError/worker=oci-rootless/frontend=client/warntype=unmarshal
daghack commented 4 days ago

After looking into it, it seems like this was simply an ephemeral failure with the test env.