moby / buildkit

concurrent, cache-efficient, and Dockerfile-agnostic builder toolkit
https://github.com/moby/moby/issues/34227
Apache License 2.0
7.83k stars 1.09k forks source link

Refactor containerd `NewWorkerOpt` & containerdexecutor `New` parameters #5086

Closed Benehiko closed 6 days ago

Benehiko commented 6 days ago

The function parameters of containerd.NewWorkerOpt and containerdexecutor.New are too long making it hard to read. This PR condenses the parameters into a singular struct.

The struct naming could be adjusted, but since I'm not too familiar with the code I tried to stick with something similar to the package and function name.

Based off of this discussion https://github.com/moby/buildkit/pull/5033#discussion_r1638659585