search

moby / buildkit

concurrent, cache-efficient, and Dockerfile-agnostic builder toolkit
https://github.com/moby/moby/issues/34227
Apache License 2.0
8.08k stars 1.14k forks source link

fix: remove default platform option from linter tests #5103

Open jsternberg opened 3 months ago

jsternberg commented 3 months ago

The progress stream would set the platform to linux/amd64 and linux/arm64 during testing. This would trigger the InvalidBaseImagePlatform rule whenever an image was pulled (usually alpine).

This removes that option as it shouldn't be necessary to run the tests.

jsternberg commented 3 months ago

I have a small concern with this PR. It seems to fix the tests, but I'm concerned that it may be masking a bug in InvalidBaseImagePlatform. For example, could this interfere with multi-platform builds?