moby / ipvs

IPVS networking for containers (package derived from moby/libnetwork)
Apache License 2.0
97 stars 37 forks source link

netlink: remove redundant check #10

Closed thaJeztah closed 4 years ago

thaJeztah commented 4 years ago

This check is already handled by NetLinkSocket.Receive() since vishvananda/netlink#125, so we can remove the check here.

noticed this while updating netlink in libnetwork

justincormack commented 4 years ago

Thats not the same fix, netlink was not setting the socket to -1 so it might become reused as another socket. This is just telling you it got closed, which should not work better. So I would leave this.

thaJeztah commented 4 years ago

🤔 hm, I probably misinterpreted 😓 closing