search

moby / ipvs

IPVS networking for containers (package derived from moby/libnetwork)
Apache License 2.0
97 stars 37 forks source link

upgrade gotest.tools to v3.4.0 to drop pkg/errors dependency #28

Closed pacoxu closed 1 year ago

pacoxu commented 1 year ago

Signed-off-by: Paco Xu paco.xu@daocloud.io

See more in https://github.com/kubernetes/kubernetes/issues/114942

pacoxu commented 1 year ago

/cc @thaJeztah

thaJeztah commented 1 year ago

@dims PTAL

thaJeztah commented 1 year ago

LOL, looks like I already had a branch doing so, but I see the last commit was "WIP";

git checkout -b remove_gotest_tools
fatal: a branch named 'remove_gotest_tools' already exists

git checkout remove_gotest_tools
git log --pretty=format:"%h%x09%an%x09%ad%x09%s"
80e9796 Sebastiaan van Stijn    Thu Mar 12 13:41:45 2020 +0100  WIP remove gotest.tools dependency
c3ff14e Sebastiaan van Stijn    Thu Mar 12 12:28:01 2020 +0100  remove unneeded _windows.go file
a43b11e Sebastiaan van Stijn    Thu Mar 12 12:14:19 2020 +0100  cleanup "ignore" files
860c90c Sebastiaan van Stijn    Thu Mar 12 12:11:56 2020 +0100  Remove testutils package
thaJeztah commented 1 year ago

I opened https://github.com/moby/ipvs/pull/29 as alternative

dims commented 1 year ago

@pacoxu let's use the other one - https://github.com/moby/ipvs/pull/29 as it drops 2 packages completely

pacoxu commented 1 year ago

close in favor of https://github.com/moby/ipvs/pull/29/