search

moby / ipvs

IPVS networking for containers (package derived from moby/libnetwork)
Apache License 2.0
97 stars 37 forks source link

Remove testutils package and minor cleanup #7

Closed thaJeztah closed 4 years ago

thaJeztah commented 4 years ago

The RunningOnCircleCI, IsRunningInContainer test-utils were no longer needed because CI is not running on CircleCI in this repo, so we don't need these utilities.

Given that the _test.go file is only built on Linux, I moved the remaining SetupTestOSContext utility to the _test.go file itself as a helper, and removed the testutils package.

There's no Dockerfile in this repo, so we can removed the .dockerignore. Also cleaned up some entries from .gitignore (more entries could probably be removed).

thaJeztah commented 4 years ago

Actually; the _test.go is linux-only, so we can likely get rid of the whole testutils directory; let me do so

thaJeztah commented 4 years ago

@dims @justincormack ptal

dims commented 4 years ago

LGTM

Way cleaner now! thanks @thaJeztah