search

moby / libnetwork

networking for containers
Apache License 2.0
2.16k stars 881 forks source link

BACKPORT: libnetwork: processEndpointCreate: Fix deadlock between getSvcRecords and processEndpointCreate #2670

Closed jdamato-fsly closed 1 year ago

jdamato-fsly commented 1 year ago

References https://github.com/moby/moby/pull/42545

Warning libnetwork was moved to https://github.com/moby/moby/tree/master/libnetwork

libnetwork has been merged to the main repo of Moby since Docker 22.06.

The old libnetwork repo (https://github.com/moby/libnetwork) now only accepts PR for Docker 20.10, and will be archived after the EOL of Docker 20.10.

reference PR: https://github.com/moby/moby/pull/42545

I've attempted to preserve the original author of the commit for full credit to them for the solution in this PR.

One person commented in the PR that they are hitting this on 20.10; I am also hitting this issue on 20.10.10 and it would be amazing if this could be merged and included in the next v20 point release!

Please let me know if there is anything I can do to help get this merged and included in the next point release.

thaJeztah commented 1 year ago

CI failures are unrelated, but I opened https://github.com/moby/libnetwork/pull/2671 to fix

thaJeztah commented 1 year ago

Did a quick rebase, as https://github.com/moby/libnetwork/pull/2671 was merged