search

moby / sys

Apache License 2.0
71 stars 41 forks source link

ci: PACKAGES hack doesn't work on Windows #156

Open kolyshkin opened 7 hours ago

kolyshkin commented 7 hours ago

Apparently the hack introduced by #145 (using custom PACKAGES list for older Go versions) is not working and never worked on Windows.

Here is an example of a run which has the full list of PACKAGES on Windows:

https://github.com/moby/sys/actions/runs/10298746983/job/28504536200

You can see it works fine on other platforms (Linux and Mac OS X).

kolyshkin commented 7 hours ago

@thaJeztah I'm thinking about a way to add a kludge to skip running a command if go version in package's go.mod is newer than that of go version.

kolyshkin commented 7 hours ago

The alternative is to drop go 1.18 support 👯