split exported functions from implementation

moby / term

Apache License 2.0

66 stars 27 forks source link

split exported functions from implementation #41

Closed thaJeztah closed 1 year ago

thaJeztah commented 1 year ago

[x] depends on https://github.com/moby/term/pull/37
[x] depends on https://github.com/moby/term/pull/43

Put the exported functions in a non-platform-specific file, and un-export the implementations. This allows us to maintain the GoDoc for exported functions in a single place (not having to repeat those), and make sure that the signatures between platforms are identical (unless not possible).

thaJeztah commented 1 year ago

This one's best reviewed commit-by-commit (as some files are renamed / moved)

thaJeztah commented 1 year ago

@rumpl doh! had one minor change stashed, and forgot to push 🙈 just did; PTAL; https://github.com/moby/term/compare/a97a5788274f401b12126432d8c4c4ee3b677a0c..bb04910d7c2ef73ab41c05aa452f86b6ac1ae7b4

thaJeztah commented 1 year ago

CI is still happy; bringing this one in 👍