term_windows: use golang.org/x/sys/windows

moby / term

Apache License 2.0

66 stars 27 forks source link

term_windows: use golang.org/x/sys/windows #9

Closed thaJeztah closed 4 years ago

thaJeztah commented 4 years ago

The parts of github.com/Azure/go-ansiterm/winterm that were used is now provided by golang.org/x/sys/windows, so switch to that package, as it's more actively maintained.

thaJeztah commented 4 years ago

@cpuguy83 @dims @tklauser PTAL

dims commented 4 years ago

LGTM !! thankfully it's mostly the same.

claudiubelu commented 4 years ago

looks pretty good. Most are simple replacements, and any other code difference looks good as well.

tiborvass commented 3 years ago

Looks like this broke users at https://github.com/docker/for-win/issues/9770, because syscall.STD_INPUT_HANDLE = -10 while windows.STD_INPUT_HANDLE = -10 & (1 << 32 - 1)

tiborvass commented 3 years ago

Unfortunately I am unable to reproduce the issue linked to confirm what caused this.