Improvements to Makefile, linting, and circleci.yml - Githubissues

moby / tool

Temporary repository for the moby assembly tool used by the Moby project

Apache License 2.0

75 stars 65 forks source link

Improvements to Makefile, linting, and circleci.yml #168

Closed dnephin closed 7 years ago

dnephin commented 7 years ago

Use gometalinter for linting

runs more linters
does everything in parallel
handles exiting with non-zero when a linter fails
supports a whitelist with // nolint
makes installation easier (install one tool then use --install instead of installing each thing separately)

Improve the cirlceci config

store the build artifacts so they can be downloaded
label the steps

Makefile improvements

put the build artifacts into a dist/ directory
run unit tests for all packages, not a single package
allow building of a binary without running lint and test every time

Cleanup vendor/

vendor.conf included some unused packages, apparently vndr is still broken and doesn't work about these unused packages.

Also fix existing lint errors.

dnephin commented 7 years ago

I also notice that this doesn't specify a go version in the circleci config. This should probably test against a specific version of go. I haven't made that change as part of this PR.