search

moby / tool

Temporary repository for the moby assembly tool used by the Moby project
Apache License 2.0
75 stars 65 forks source link

Tweak circleci config to try and fix artifact upload #182

Closed ijc closed 6 years ago

ijc commented 6 years ago

Signed-off-by: Ian Campbell ijc@docker.com

I don't know why but the current arrangement seems to not be working, at least the two most recent master builds seem to lack them: https://circleci.com/gh/moby/tool/292#artifacts/containers/0 https://circleci.com/gh/moby/tool/289#artifacts/containers/0

I can't see anything wrong with the existing file, but try perturbing it...

ijc commented 6 years ago

https://circleci.com/gh/moby/tool/286#artifacts/containers/0 (third most recent, two weeks ago) also lacks them.

ijc commented 6 years ago

BTW The commit message is non-existent since I have not idea WTF is going wrong, I'll experiment here and write something proper when I (think I) understand

ijc commented 6 years ago

OK, I think the issue is that the $GOPATH in working_directory is being treated as a literal GOPATH at least when processing the state_artifacts.path! Inlining it seems to have worked, at the cost of some duplication..

dnephin commented 6 years ago

Looks like that fixed it!

Maybe add a destination to store_artifacts as well, so the directory tree isn't as crazy in the UI ? (https://circleci.com/docs/2.0/configuration-reference/#store_artifacts)

ijc commented 6 years ago

Ah, I'd been wondering how to fix that in another context too, will do!

ijc commented 6 years ago

TIL the difference between artefact and artifact too!