vmnet: move vmnet to its own package

moby / vpnkit

A toolkit for embedding VPN capabilities in your application

Apache License 2.0

1.1k stars 187 forks source link

Closed tiborvass closed 5 years ago

tiborvass commented 5 years ago

This allows library users to import vmnet without datakit.

Signed-off-by: Tibor Vass tibor@docker.com

samoht commented 5 years ago

LGTM but I am just curious about the context in which this change is needed as I thought vmnetd was already independant of datakit.

tiborvass commented 5 years ago

@samoht it's used in https://github.com/rootless-containers/rootlesskit and we discovered the unnecessary datakit dependency. Right now, the other files from the vpnkit package depend on datakit.

tiborvass commented 5 years ago

@samoht and we use rootlesskit in buildkit :)

djs55 commented 5 years ago

Also LGTM!