search

moby / vpnkit

A toolkit for embedding VPN capabilities in your application
Apache License 2.0
1.1k stars 188 forks source link

CircleCI build artifact is invisible to non-maintainers #431

Closed AkihiroSuda closed 5 years ago

AkihiroSuda commented 6 years ago

CircleCI build artifact is invisible to non-maintainers, but I'm not sure how to fix the issue.

Maybe the best ways is to ship regular binary release for non-maintainers.

(I want Linux binary artifact as well, because RootlessKit CI spends most time in building VPNKit for integration testing)

djs55 commented 6 years ago

A regular binary release sounds like a good idea.

Making portable Linux binaries from OCaml programs is a little tricky, as the OCaml runtime links against the system libc (unlike Go). Maybe a static link would work. Otherwise we'll have to choose which environment(s) to build it in and publish multiple binaries.

AkihiroSuda commented 6 years ago

Yes, static link (with musl) is possible https://github.com/moby/vpnkit/issues/407#issuecomment-404777050

djs55 commented 5 years ago

For Linux the Dockerfile now builds a static binary (with musl) and there's a hub auto-builder which creates this image:

docker run djs55/vpnkit:latest /vpnkit --help
AkihiroSuda commented 5 years ago

Thanks!