Add Kubernetes controller used by Docker Desktop

moby / vpnkit

A toolkit for embedding VPN capabilities in your application

Apache License 2.0

1.1k stars 187 forks source link

Add Kubernetes controller used by Docker Desktop #450

Closed guillaumerose closed 5 years ago

guillaumerose commented 5 years ago

This PR also contains:

Add Kubernetes controller used by Docker Desktop. For the moment, just as a package, that can be used on the host (not in the VM yet).
Move from vndr to go dep: dep was already used by the binary kube-vpnkit-forwarder. It's too complicated to vendor Kubernetes with vndr.
Fix one go unit test failure

One question, I have: vendoring of linuxkit/virtualsock seems to be really old. Can we update it ?

justincormack commented 5 years ago

I beleive the vsock vendoring is old as you are still running patched 4.9 kernels which is before the interface changes for hvsock.

djs55 commented 5 years ago

Yes unfortunately we can't update the vsock version until we've bumped the kernel version (which requires some more bugfixing).

guillaumerose commented 5 years ago

Can I use the tag end_10586_support or 10586_fixes in virtsock ?

In Docker Desktop, we are using 10586_fixes.

djs55 commented 5 years ago

The changes in 10586_fixes look safe enough (and some of them could be useful)

djs55 commented 5 years ago

I'll merge this since the CI is green. Feel free to open a new PR to revenuer 10586_fixes if you'd like.

guillaumerose commented 5 years ago

Thanks!

Le ven. 25 janv. 2019 17:29, David Scott notifications@github.com a écrit :

Merged #450 https://github.com/moby/vpnkit/pull/450 into master.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/moby/vpnkit/pull/450#event-2097618680, or mute the thread https://github.com/notifications/unsubscribe-auth/AAKiUJ0EgyRjqEPzAWCIjgNiyGi-UsgZks5vGzD7gaJpZM4aSxLT .