moby / vpnkit

A toolkit for embedding VPN capabilities in your application
Apache License 2.0
1.1k stars 187 forks source link

When calling OnUpdate, Kubernetes controller now closes removed ports #466

Closed guillaumerose closed 5 years ago

guillaumerose commented 5 years ago

The current implementation of the Kubernetes controller doesn't handle update properly.

For instance, if I deploy an nginx and expose it:

kubectl run --image nginx nginx
kubectl expose deploy nginx --port 80 --type=NodePort

Then after change the port using kubectl edit svc nginx. Two ports are now opened. The original port should be close.

djs55 commented 5 years ago

Looks good to me!