multiuser support for rootless docker

moby / vpnkit

A toolkit for embedding VPN capabilities in your application

Apache License 2.0

1.1k stars 187 forks source link

multiuser support for rootless docker #471

Closed eschen42 closed 5 years ago

eschen42 commented 5 years ago

fix issue 'rootless docker works for only one user' rootlesskit issue 56

GordonTheTurtle commented 5 years ago

Please sign your commits following these rules: https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work The easiest way to do this is to amend the last commit:

$ git clone -b "multiuser" git@github.com:eschen42/vpnkit.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842358455464
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

AkihiroSuda commented 5 years ago

wondering this pcap code was for debugging purpose and left over in the repo by accident?

eschen42 commented 5 years ago

In the "eat your own dogfood" department, I am happy to report that I ran

cd go && make build-in-container

and it passed on my machine that is only running get.docker.com/rootless with a substituted rootlesskit built with this change, and the test passed.

djs55 commented 5 years ago

Sorry I hadn't spotted this PR. I think the pcap code was left in by accident -- it was indeed intended for debugging.

Since #472 removes the pcap code I'll close this PR.