Closed djs55 closed 3 years ago
Looks like your git config doesn't match your sign-off; (DCO check can be picky with that)
Commit sha: ac55ea3, Author: David Scott, Committer: David Scott; Expected "David Scott dave@recoil.org", but got "David Scott dave.scott@docker.com".
@thaJeztah ah yes, I'd better fix that!
I should mention that you can manually mark it to "pass" if needed. Not sure if it supports a .mailmap
file (which could work for this otherwise)
lgtm
OK I'm able to vendor this into another repo successfully 😅 ... the true test of go.mod
Regarding CI:
opam monorepo
which is blocked on switching uwt
for luv
and updating the tcpip
package version)
Although the go code is tested by CI on Linux, the Mac CI is currently broken and doesn't pick up failures in Mac-specific parts.