go: switch to go.mod, Mac build fixes

moby / vpnkit

A toolkit for embedding VPN capabilities in your application

Apache License 2.0

1.1k stars 187 forks source link

go: switch to go.mod, Mac build fixes #514

Closed djs55 closed 3 years ago

djs55 commented 3 years ago

Although the go code is tested by CI on Linux, the Mac CI is currently broken and doesn't pick up failures in Mac-specific parts.

thaJeztah commented 3 years ago

Looks like your git config doesn't match your sign-off; (DCO check can be picky with that)

Commit sha: ac55ea3, Author: David Scott, Committer: David Scott; Expected "David Scott dave@recoil.org", but got "David Scott dave.scott@docker.com".

djs55 commented 3 years ago

@thaJeztah ah yes, I'd better fix that!

thaJeztah commented 3 years ago

I should mention that you can manually mark it to "pass" if needed. Not sure if it supports a .mailmap file (which could work for this otherwise)

simonferquel commented 3 years ago

lgtm

djs55 commented 3 years ago

OK I'm able to vendor this into another repo successfully 😅 ... the true test of go.mod

Regarding CI:

travis: hit a Docker rate limit
circleci: broken for an unrelated reason (fixed in a concurrent PR)
appveyor: Windows is broken and can't be fixed until we get rid of the Cygwin dependency (currently blocked on using opam monorepo which is blocked on switching uwt for luv and updating the tcpip package version)
DCO: pass!