search

moby / vpnkit

A toolkit for embedding VPN capabilities in your application
Apache License 2.0
1.1k stars 187 forks source link

Work around build failure in uri package #517

Closed djs55 closed 3 years ago

djs55 commented 3 years ago

The failure looks like:

ocamlc lib/.uri.objs/byte/uri_re.{cmi,cmo,cmt} (exit 2)
(cd _build/default && /home/opam/.opam/4.07/bin/ocamlc.opt -w -40 -g -bin-annot -I lib/.uri.objs/byte -no-alias-deps -o lib/.uri.objs/byte/uri_re.cmo -c -impl lib/.wrapped_compat/Uri_re.ml-gen)
File "lib/.wrapped_compat/Uri_re.ml-gen", line 1, characters 99-110:
Error: Unbound module Uri__Uri_re

I suspect it's due to a missed dependency within the code itself, probably due to the old packages and dune/jbuilder version. Building the package separately seems to hide the problem, which is enough until we can upgrade a lot of the dependencies.

Signed-off-by: David Scott dave@recoil.org

djs55 commented 3 years ago

This seems to have fixed the build well enough for me to build and push this image: https://hub.docker.com/layers/djs55/vpnkit/7f0eff0dd99b576c5474de53b4454a157c642834/images/sha256-81b2b42c9be1c14882e762a1ff2c55e210e7786b3a9d4844dc06d38436af79f0?context=repo

djs55 commented 3 years ago

Unfortunately the CI does not test the Dockerfile build :(