search

moby / vpnkit

A toolkit for embedding VPN capabilities in your application
Apache License 2.0
1.09k stars 182 forks source link

Fix build on MacOS by tagging specific commits #549

Closed ar2pi closed 2 years ago

ar2pi commented 2 years ago

Currently the build fails on MacOS because branch gerd/disable-parallel-bootstrap is no longer present in omake repo.

We can fix this by tagging the specific commit (that hopefully will never disappear).

Same applies for tcpip.3.3.0, even though branch vpnkit-20210417 is still there, it seems safer to reference by commit (or tag if available).

omake commit 0e4aef74dfe005b4e880cd13c08f7c57fa4a030b tcpip.3.3.0 commit 551a52855ffb6b794b582906fe1fc9c841e0d89b

djs55 commented 2 years ago

Build should be fixed, so I'll close this PR. Let me know if you have any more problems!