search

moby / vpnkit

A toolkit for embedding VPN capabilities in your application
Apache License 2.0
1.11k stars 190 forks source link

Don't calculate high_ip in DHCP configuration and zap outdated comment #556

Closed haesbaert closed 2 years ago

haesbaert commented 2 years ago

This is a left over from when charrua would only work if there was a delta of at least one between min and max addresses.

Also zap two outdated comments related to the same issue.

I can't really test this code since I have no environment so please be careful.

Relevant commits https://github.com/mirage/charrua/commit/3c1995bab9679c0105c962d269bec92806868ffa https://github.com/mirage/charrua/commit/0bb4464f41dab7fadc37bdda606fe76edaefc6d3

djs55 commented 2 years ago

The CircleCI build for unrelated reasons (a pinned OCaml branch has been deleted -- I need to update it to a sha in the master branch)

djs55 commented 2 years ago

I'll fix CircleCI separately and then merge this.

djs55 commented 2 years ago

CircleCI is fixed on the master branch, I'll merge this.