search

moby / vpnkit

A toolkit for embedding VPN capabilities in your application
Apache License 2.0
1.1k stars 187 forks source link

Update licenses versions #569

Closed mat007 closed 2 years ago

mat007 commented 2 years ago

https://github.com/mirage/mirage-channel/releases/tag/v4.1.0 was released a few hours ago.

I’m still a bit puzzled as to why the dependencies aren’t pinned. What did I miss? 🤔

mat007 commented 2 years ago

CircleCI build doesn’t agree that the versions need to be bumped

Fatal error: exception Failure("unknown licenses for ppx_cstruct.6.0.1, mirage-channel.4.0.1, cstruct-sexp.6.0.1, cstruct-lwt.6.0.1, cstruct.6.0.1")

🤔

djs55 commented 2 years ago

Hm, not sure if that's because of non-determinism in the package manager's SAT solver (😬 )or something else. I'll take a look at pinning.

mat007 commented 2 years ago

or something else

Maybe there is a diamond style dependency with both versions still being needed.

djs55 commented 2 years ago

As an experiment I've added version pins for the direct dependencies in this PR: https://github.com/moby/vpnkit/pull/570

There may be indirect dependencies too but I don't have a nice way to pin those, except by making them direct dependencies. I suspect it's the direct dependencies that change the most often (like the ones in this PR).

djs55 commented 2 years ago

CI is green on Mac and Win (ocaml-ci is known to be broken)