search

moby / vpnkit

A toolkit for embedding VPN capabilities in your application
Apache License 2.0
1.09k stars 182 forks source link

Ensure uname subprocess is cleaned up #593

Closed tmoschou closed 1 year ago

tmoschou commented 1 year ago

Adds a fix to the uname command / subprocess spawned which was not cleaned up / reaped appropriately on Darwin. The result was a zombie process / resource leak that lingered in the process table.

Fixes #592

tmoschou commented 1 year ago

Looks like CircleCI is using Xcode 12.0.0 which is no longer supported https://circleci.com/docs/xcode-policy#xcode-image-retention-and-deprecation https://circleci.com/docs/using-macos#supported-xcode-versions

djs55 commented 1 year ago

I've taken the liberty of force-pushing a rebase after the recent CI improvements.

djs55 commented 1 year ago

OK, CI is a bit greener :)