moby / vpnkit

A toolkit for embedding VPN capabilities in your application
Apache License 2.0
1.09k stars 182 forks source link

Compilation error due to "Unbound module Ethernet__Ethernet_wire" #630

Open gspadotto opened 1 year ago

gspadotto commented 1 year ago

I am trying to build the repository from the master branch (as there are no binary distributions) on a Mac, but there are references to data structures that are no more present in "ethernet" {>= "3.0.0"}:

https://github.com/moby/vpnkit/blob/ee2e5c0f7fd3100715957af2d6b497fbf90806db/src/hostnet/hostnet_dns.ml#L256

I also had to comment out these lines: https://github.com/moby/vpnkit/blob/master/dune#L14-L17

valof commented 5 months ago

similar here, trying to build for Ubuntu:

xxx@DESKTOP-ES15K2K:~/git/vpnkit$ make opam exec -- dune build --profile release make[1]: Entering directory '/home/xxx/git/vpnkit/_build/default' GEN src/bin/version.ml make[1]: Leaving directory '/home/xxx/git/vpnkit/_build/default' File "src/hostnet/hostnet_dns.ml", line 260, characters 6-46: 260 | Ethernet__Ethernet_wire.set_ethernet_src smac 0 frame; ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Error: Unbound module Ethernet__Ethernet_wire File "dune", line 14, characters 0-127: 14 | (rule 15 | (target licenses.json) 16 | (deps deps.csv (:gen ./scripts/licenses.exe)) 17 | (action (run %{gen} -out %{target} -in %{deps}))) Fatal error: exception Failure("unknown licenses for uri-sexp.4.4.0, uri.4.4.0, sha.1.15.4, re.1.11.0, ptime.1.1.0, ppx_cstruct.6.2.0, ounit2.2.2.7, ounit.2.2.7, optint.0.3.0, ocaml-system.4.13.1, num.1.5, mirage-kv.6.1.1, metrics.0.4.1, menhirSdk.20231231, menhirLib.20231231, menhirCST.20231231, menhir.20231231, macaddr-sexp.5.5.0, macaddr-cstruct.5.5.0, macaddr.5.5.0, lwt.5.7.0, luv_unix.0.5.1, luv.0.5.12, jsonm.1.0.2, ipaddr-sexp.5.5.0, ipaddr.5.5.0, ethernet.3.2.0, dune-configurator.3.13.0, dune.3.13.0, ctypes.0.21.1, cstruct-sexp.6.2.0, cstruct-lwt.6.2.0, cstruct.6.2.0, csexp.1.5.2, cohttp-lwt.5.3.0, cohttp.5.3.1, bigstringaf.0.9.1, base64.3.5.1, arp.3.1.0, angstrom.0.16.0") make: *** [Makefile:6: vpnkit.exe] Error 1

RyanGibb commented 4 months ago

Looks like this is due to https://github.com/mirage/ethernet/pull/10/commits/61dfc143518fadb5610473e533f75c2a2856b7da