mocaccinoOS / mocaccino

:musical_score: where magic happens
69 stars 7 forks source link

ISO images are not recognized by Gnome Boxes #84

Open msdobrescu opened 2 years ago

msdobrescu commented 2 years ago

Luet version:

CPU architecture, OS, and Version:

Describe the bug

Gnome Boxes does not create a machine from the ISO image. The error is thrown in the logs like:

(gnome-boxes:3): Boxes-WARNING **: 20:35:39.409: index-page.vala:177: Failed to create installer media for path 'MocaccinoOS-KDE-0.20220618.iso': Insufficient metadata on installation media

To Reproduce

Open Gnome Bioxes, issue , select the ISO image. Apparently nothing happens, no message (Gnome Boxes UI issue)

Expected behavior

The ISO is used, the OS detected, the image created.

Logs

Additional context

Looking here, shows it needs to add more parameterization to the luet-makeiso plugin and mode info here and here.

I have used this to set the volume id: ./isovolid.pl <file>.iso Mocaccino

isovolid.pl:

#!/usr/bin/perl

use strict;
use warnings;
die "Use: $0 <iso_file> <new volume id>\n" unless @ARGV == 2;
open my $file, "+<", $ARGV[0] or die "Cannot open: $!";
seek $file, 0x8028,0;
printf $file "%-32.32s", uc($ARGV[1]);

As effect, Gnome Boxes already started to work with it. I would add system id and publisher id values too.

joostruis commented 2 years ago

If we compare with what Fedora image has:

joost@xbox-360 /run/media/joost/data/iso $ isoinfo -d -i Fedora-Workstation-Live-x86_64-36-1.5.iso 
Setting input-charset to 'UTF-8' from locale.
CD-ROM is in ISO 9660 format
System id: 
Volume id: Fedora-WS-Live-36-1-5
Volume set id: 
Publisher id: 
Data preparer id: XORRISO-1.5.4 2021.01.30.150001, LIBISOBURN-1.5.4, LIBISOFS-1.5.4, LIBBURN-1.5.4
Application id: 
Copyright File id: 
Abstract File id: 
Bibliographic File id: 
Volume set size is: 1
Volume set sequence number is: 1
Logical block size is: 2048
Volume size is: 985424
El Torito VD version 1 found, boot catalog is in sector 42

Joliet with UCS level 3 found.
SUSP signatures version 1 found
Rock Ridge signatures version 1 found
Rock Ridge id 'RRIP_1991A'
Eltorito validation header:
    Hid 1
    Arch 0 (x86)
    ID ''
    Cksum AA 55 OK
    Key 55 AA
    Eltorito defaultboot header:
        Bootid 88 (bootable)
        Boot media 0 (No Emulation Boot)
        Load segment 0
        Sys type 0
        Nsect 4
        Bootoff 3DA6 15782

You can see that the Volume id is set. I think it would be enough if we can set this.

joostruis commented 8 months ago

@msdobrescu can we close this?

msdobrescu commented 8 months ago

Although it works now, it is not fully implemented. I would not close it or I would add a new one to fully implement the details.