search

moccu / django-omnibus

django-omnibus is a Django library which helps to create websocket-based connections between a browser and a server to deliver messages.
BSD 3-Clause "New" or "Revised" License
70 stars 14 forks source link

Don't break if there's a custom user model #4

Closed andybak closed 10 years ago

EnTeQuAk commented 10 years ago

@andybak as the User model is only used in UserAuthenticator.authenticate it would be best to move the import plus the get_user_model call to this method.

This should restore Django 1.7 compatibility. You may check Travis output.

andybak commented 10 years ago

OK. Done that and added a comment. Apologies for not testing at this end. Thought it was a simple fix and hadn't taken into account the new app registry stuff!

EnTeQuAk commented 10 years ago

No worries, testing all those Django versions is nasty but unfortunately we will have to do this for some Django versions to come.

Waiting for Travis and merging then.

Thanks a lot! :cake: :star2: :smile_cat:

andybak commented 10 years ago

Damn. Getting a pep8 failure but looks like me and pep8 disagree on this one!

EnTeQuAk commented 10 years ago

@andybak don't worry about that, I'm merging now and fix the pep8 error along the way

EnTeQuAk commented 10 years ago

@andybak Thanks again for all those patches!

andybak commented 10 years ago

Thank you. You saved me from having to start using server-side javascript. :)