search

moccu / django-omnibus

django-omnibus is a Django library which helps to create websocket-based connections between a browser and a server to deliver messages.
BSD 3-Clause "New" or "Revised" License
70 stars 14 forks source link

Added support for secure WebSockets #9

Closed CPlusPlus17 closed 10 years ago

CPlusPlus17 commented 10 years ago

My English is not the best, maybe you want to adjust the documentation to fit your standards. :)

EnTeQuAk commented 10 years ago

Hey @ManuelGysin - thanks a lot for the pull request!

I am actually not sure if we really want ssl support in omnibus directly. I'd rather see the documentation adapted with howtos to use nginx, apache etc as a https-proxy or an example using stunnel as a tunnel for local development.

Let me know what you think

CPlusPlus17 commented 10 years ago

Hello!

To be honest, I'm not very familiar with websockets nor how to protect them the right way. But in my opinion direct support would help to make the web a bit more secure, most people are not willing to install https-proxies or stuff like that and so they just skip the SSL part. (Deployment gets much more complex)

I can't estimate the impact of adding the SSL layer directly to omnibus. Sure there is some more CPU work to do but it will help to keep the deployment small. The other part is with omnibus and http-proxy in use the network debugging part could get much more complex.

coveralls commented 10 years ago

Coverage Status

Coverage decreased (-1.65%) when pulling 441824b398faee8701b7fced286217fe6b0c66cd on ManuelGysin:master into f3c453a8fdf145e5a4ef1d5ab46fb380d6a3cab6 on moccu:master.

EnTeQuAk commented 10 years ago

Thanks again for all the work you did. I'm going to close this in favor of https://github.com/moccu/django-omnibus/issues/17 to give this topic a bigger picture.