search

mocdaniel / dashing-icinga2

Dashing dashboard for Icinga 2 using the REST API
MIT License
205 stars 47 forks source link

Use Chartjs update() and rebuild chart only when necessary #97

Closed coderobe closed 4 years ago

coderobe commented 4 years ago

This fixes https://github.com/dnsmichi/dashing-icinga2/issues/93

Some of the arguments to circularChart and linearChart are now unused and should maybe also be dropped.

dnsmichi commented 4 years ago

I've already tested it, but ran into a legend on top not right problem with the hosts chart. I need a free slot to dive into this again.

coderobe commented 4 years ago

The legend alignment bug is present in your current master HEAD as well. It is not a side effect of this PR specifically

coderobe commented 4 years ago

(this was also mentioned in #93 by the original reporter and confirmed by me, before this PR was born)

dnsmichi commented 4 years ago

Hm strange, I just didn't have that before in my environment, now it is permanent. Thanks for clarifying.